http://gwt-code-reviews.appspot.com/103812/diff/5/1003 File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/5/1003#newcode234 Line 234: public static boolean isUsingRemoteUI() { I agree that the code should be in DevModeBase and that we should consider not using a system property. The approach being considered here is whether we can make some of the log levels dynamic based on the UI (or other criteria). That way the Swing UI can use the log levels that it wants and the RemoteUI (i.e. the Eclipse view) can get a quieter environment. One possibility is to modify DevModeBase.createUI to get the currently configured SCL and set some "default" log level on it if it is the JettyLauncher. Or something that enables the JettyLauncher to delegate some of its log level selections to it. If we do this right, we might be able to extend this approach to introduce similar dynamic log level determination based on ui into r7003. On 2009/11/19 00:48:47, jat wrote: > Why isn't this in DevModeBase, since that is where the property is set? http://gwt-code-reviews.appspot.com/103812/diff/5/1005 File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java (right): http://gwt-code-reviews.appspot.com/103812/diff/5/1005#newcode85 Line 85: if (DevMode.isUsingRemoteUI()) { If we were to set a default log level for status messages on the SCL you could just initialize logStatus with that value and only apply your override behavior here. On 2009/11/19 00:48:47, jat wrote: > How about setting this above, something like: > TreeLogger.Type normalLogLevel = DevMode.isUsingRemoteUI() ? TreeLogger.TRACE : > TreeLogger.INFO; > and then using that where appropriate? I think that woud make this easier to > read. http://gwt-code-reviews.appspot.com/103812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
