Reviewers: bobv,

Message:
Review requested.

Description:
We were generating bad code when @UiFactory was put
on a method with a parameterized return type. The
solution here is simplistic, treating everything
as the raw type and not validating that the
param type matches what is expected in the template,
but I think it's an improvement.

The actual fix is small, but the change to the
test classes is pretty big: OwnerClassTest no
longer uses JClassTypeAdapter, which I'm hoping eventually
to delete in favor of mock compile state. This was necessary
because JClassTypeAdapter doesn't deal with generics.

Please review this at http://gwt-code-reviews.appspot.com/106801

Affected files:
   M user/src/com/google/gwt/uibinder/rebind/model/OwnerClass.java
   M user/test/com/google/gwt/uibinder/UiBinderGwtSuite.java
   M user/test/com/google/gwt/uibinder/rebind/model/OwnerClassTest.java
   M user/test/com/google/gwt/uibinder/test/UiJavaResources.java
   A user/test/com/google/gwt/uibinder/test/client/Abstract.java
   A user/test/com/google/gwt/uibinder/test/client/ParameterizedWidgets.java
   A  
user/test/com/google/gwt/uibinder/test/client/ParameterizedWidgets.ui.xml
   A  
user/test/com/google/gwt/uibinder/test/client/TestParameterizedWidgets.java


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to