Looks right, but questions since I don't know this world.

http://gwt-code-reviews.appspot.com/106803/diff/18/19
File user/src/com/google/gwt/rpc/server/RPC.java (right):

http://gwt-code-reviews.appspot.com/106803/diff/18/19#newcode217
Line 217: throw new SerializationException(
I take it there's an existing mechanism to turn SerializationException
into a 505?

http://gwt-code-reviews.appspot.com/106803/diff/18/20
File
user/src/com/google/gwt/user/server/rpc/AbstractRemoteServiceServlet.java
(right):

http://gwt-code-reviews.appspot.com/106803/diff/18/20#newcode107
Line 107: throw new RuntimeException("Unable to report failure", e);
So "Unable to report failure" will not reach the client, right?

http://gwt-code-reviews.appspot.com/106803/diff/18/21
File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
(right):

http://gwt-code-reviews.appspot.com/106803/diff/18/21#newcode261
Line 261:
response.getOutputStream().write(GENERIC_FAILURE_MSG.getBytes("UTF-8"));
why?

http://gwt-code-reviews.appspot.com/106803/diff/18/22
File
user/test/com/google/gwt/user/client/rpc/RemoteServiceServletTest.java
(right):

http://gwt-code-reviews.appspot.com/106803/diff/18/22#newcode214
Line 214: public void testUnknownRuntimeException() {
Thank you! This test is run against both legacy and deRPC?

http://gwt-code-reviews.appspot.com/106803

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to