w00t! I'm so happy you said that, I was really hoping the possible "annoyance" factor of some false alarms would be outweighed by actually helping people catch errors more quickly.
On Thu, Nov 19, 2009 at 6:17 PM, Matthew Mastracci <[email protected]>wrote: > Thanks for the quick fix. The stricter JSNI parser caught some pretty > brain-dead JSNI generation errors on my part, which I'm happy to see. > > Matt. > > On Thu, Nov 19, 2009 at 3:01 PM, Scott Blum <[email protected]> wrote: > > Yeah, sorry about that,. I just checked a bunch of stuff into trunk that > > should fix this. > > > > On Thu, Nov 19, 2009 at 1:50 PM, Matt Mastracci <[email protected]> > > wrote: > >> > >> Thanks, Scott. I'm applying it now and building GWT. It's been > catching > >> some JSNI refs in the GWT source, possibly some false-positive (the > >> JSONParser ones seem to be valid?). The build doesn't actually fail, > though: > >> [java] [WARN] Warnings in > >> > 'jar:file:/Users/matthew/Documents/dotspots/gwt/trunk-clean/build/lib/gwt-user.jar!/com/google/gwt/emul/java/util/AbstractHashMap.java' > >> [java] [WARN] Line 293: Referencing method > >> > 'java.util.AbstractHashMap$MapEntryString.new(Ljava/util/AbstractHashMap;Ljava/lang/String;)': > >> unable to resolve method, expect subsequent failures > >> [java] [WARN] Line 432: Referencing method > >> 'java.util.MapEntryImpl.new(Ljava/lang/Object;Ljava/lang/Object;)': > unable > >> to resolve method, expect subsequent failures > >> [java] [WARN] Warnings in > >> > 'jar:file:/Users/matthew/Documents/dotspots/gwt/trunk-clean/build/lib/gwt-user.jar!/com/google/gwt/layout/client/LayoutImplIE6.java' > >> [java] [WARN] Line 338: Referencing method > >> 'com.google.gwt.layout.client.Layout.Alignment.ordinal()': unable to > resolve > >> method, expect subsequent failures > >> [java] [WARN] Line 340: Referencing method > >> 'com.google.gwt.layout.client.Layout.Alignment.ordinal()': unable to > resolve > >> method, expect subsequent failures > >> [java] [WARN] Warnings in > >> > 'jar:file:/Users/matthew/Documents/dotspots/gwt/trunk-clean/build/lib/gwt-user.jar!/com/google/gwt/json/client/JSONParser.java' > >> [java] [WARN] Line 98: Referencing method > >> > 'com.google.gwt.json.client.JSONArray.new(Lcom/google/gwt/core/client/JavaScriptObject;)': > >> unable to resolve method, expect subsequent failures > >> [java] [WARN] Line 102: Referencing method > >> > 'com.google.gwt.json.client.JSONObject.new(Lcom/google/gwt/core/client/JavaScriptObject;)': > >> unable to resolve method, expect subsequent failures > >> On 19-Nov-09, at 9:18 AM, Scott Blum wrote: > >> > >> @Matt: IIRC you are hittnig this because you have a parse error in one > of > >> your JSNI methods. Either apply my patch and try it again, or else > binary > >> search for the offending method by commenting hafl of them out at a > time. > >> The good news is the error will likely repro in hosted mode, so it > >> shouldn't take too long. > >> -- > >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
