Reviewers: jat,

Message:
Some notes:


http://gwt-code-reviews.appspot.com/112801/diff/1007/15
File plugins/npapi/LocalObjectTable.h (right):

http://gwt-code-reviews.appspot.com/112801/diff/1007/15#newcode74
Line 74: setFree(id);
This was causing a debug check to fail.  If you do the setFree(id)
first, it invalidates the iterator and it->second gets crashy.

http://gwt-code-reviews.appspot.com/112801/diff/1007/18
File plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (right):

http://gwt-code-reviews.appspot.com/112801/diff/1007/18#newcode3
Line 3: "version": "1.0",
For some reason my version of Chrome doesn't like the numbers to the
left!  I dunno why.

Description:
Hi John,

This patch does two things:

1) Fails gracefully in the face of a disconnect, returning undefined
instead of making lots of noise.

2) Invokes hosted.html's __gwt_disconnected() method the first time the
session is detected as dropped.  This glasspanels the app.

"It works" but it's kind of hacked in; I have no idea what the right
design is as far as who should actually detect the session dropping and
try to do the glasspanel call.


Please review this at http://gwt-code-reviews.appspot.com/112801

Affected files:
   M plugins/ie/oophm/oophm/IESessionHandler.cpp
   M plugins/ie/oophm/oophm/IESessionHandler.h
   M plugins/ie/oophm/oophm/JavaObject.cpp
   M plugins/ie/oophm/oophm/SessionData.h
   M plugins/npapi/LocalObjectTable.h
   M plugins/npapi/ScriptableInstance.cpp
   M plugins/npapi/ScriptableInstance.h
   M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to