Reviewers: bruce, Description: These have been moved to bug entries.
Please review this at http://gwt-code-reviews.appspot.com/112806 Affected files: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html =================================================================== --- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (revision 7118) +++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (working copy) @@ -1,7 +1,5 @@ <html> <head><script> -// TODO(jat): wrap these to reduce namespace issues, and refactor code into -// separate functions. var $wnd = parent; var $doc = $wnd.document; var $moduleName, $moduleBase, $entry @@ -51,7 +49,6 @@ var ua = navigator.userAgent.toLowerCase(); if (ua.indexOf("gecko") != -1) { // install eval wrapper on FF to avoid EvalError problem - // TODO(jat): should this UA check be more specific (this hits chrome too)? var __eval = window.eval; window.eval = function(s) { return __eval(s); @@ -226,21 +223,7 @@ $moduleName = modName; $moduleBase = modBase; - /* - * NOTE: this presently sucks and is the only formulation I can find that will - * work across browsers. On a Windows box where both plugins are registered, - * FF will instantiate the (non-working) IE plugin. But plugins have problems - * that prevent making this easy. - * - * The IE plugin will throw an exception in FF if you try to resolve - * "pluginObject.connect" as a value. Thus the try/catch below. - * - * The FF plugin will actually do illegal crashy things in IE if you try to - * resolve "pluginEmbed.connect" as a value. Thus we have to try the IE - * plugin first. - * - * Both plugins need some work to make them truly safe. - */ + // Note that the order is important var pluginFinders = [ findPluginXPCOM, findPluginObject, @@ -304,8 +287,6 @@ } window.onunload = function() { - // TODO: do we need to do anything here or just rely on the plugins - // unload call? }; // Lightweight metrics -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
