Revision: 7141 Author: [email protected] Date: Mon Nov 23 15:04:10 2009 Log: Remove TODOs from hosted.html, captured in issues instead.
Patch by: jat Review by: bruce http://code.google.com/p/google-web-toolkit/source/detail?r=7141 Modified: /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html ======================================= --- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 14:39:18 2009 +++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 15:04:10 2009 @@ -1,7 +1,5 @@ <html> <head><script> -// TODO(jat): wrap these to reduce namespace issues, and refactor code into -// separate functions. var $wnd = parent; var $doc = $wnd.document; var $moduleName, $moduleBase, $entry @@ -51,7 +49,6 @@ var ua = navigator.userAgent.toLowerCase(); if (ua.indexOf("gecko") != -1) { // install eval wrapper on FF to avoid EvalError problem - // TODO(jat): should this UA check be more specific (this hits chrome too)? var __eval = window.eval; window.eval = function(s) { return __eval(s); @@ -221,21 +218,7 @@ $moduleName = modName; $moduleBase = modBase; - /* - * NOTE: this presently sucks and is the only formulation I can find that will - * work across browsers. On a Windows box where both plugins are registered, - * FF will instantiate the (non-working) IE plugin. But plugins have problems - * that prevent making this easy. - * - * The IE plugin will throw an exception in FF if you try to resolve - * "pluginObject.connect" as a value. Thus the try/catch below. - * - * The FF plugin will actually do illegal crashy things in IE if you try to - * resolve "pluginEmbed.connect" as a value. Thus we have to try the IE - * plugin first. - * - * Both plugins need some work to make them truly safe. - */ + // Note that the order is important var pluginFinders = [ findPluginXPCOM, findPluginObject, @@ -299,8 +282,6 @@ } window.onunload = function() { - // TODO: do we need to do anything here or just rely on the plugins - // unload call? }; // Lightweight metrics -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
