Reviewers: bobv,
Message:
Review requested.
Description:
When I revamped AttributeParsing last week, I made it impossible to set
styleName to an empty string. That's a regression.
Attribute parsing has inconsistently made the assumption that setting an
attribute to "" is the same as not setting it. That is, <foo bar=""> ==
<foo />. Following that rule during the revamp is part of what lead to
this bug--turns out that people already rely on <foo bar=''> causing
foo.bar("") to be generated.
So, this patch makes the parsers consistently return null for a missing
attribute, and "" only when the user actually provides it.
Please review this at http://gwt-code-reviews.appspot.com/112812
Affected files:
M
user/src/com/google/gwt/uibinder/attributeparsers/StrictAttributeParser.java
M user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
M
user/src/com/google/gwt/uibinder/elementparsers/DisclosurePanelParser.java
M user/src/com/google/gwt/uibinder/elementparsers/LayoutPanelParser.java
M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
M user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java
M
user/test/com/google/gwt/uibinder/attributeparsers/IntAttributeParserTest.java
M
user/test/com/google/gwt/uibinder/attributeparsers/LengthAttributeParserTest.java
M
user/test/com/google/gwt/uibinder/attributeparsers/StringAttributeParserTest.java
M user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java
M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
