Revision: 7206 Author: [email protected] Date: Mon Nov 30 16:12:52 2009 Log: Fixes a crashy over-releasing bug in FF plugin.
We were failing to AddRef the topWin reference, which would cause random crashes later. Patch by: me, jat (pair prog) Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7206 Modified: /trunk/plugins/xpcom/ExternalWrapper.cpp ======================================= --- /trunk/plugins/xpcom/ExternalWrapper.cpp Mon Nov 23 15:38:51 2009 +++ /trunk/plugins/xpcom/ExternalWrapper.cpp Mon Nov 30 16:12:52 2009 @@ -177,7 +177,7 @@ << Debug::flush; return false; } - *topWinRet = topWinInt; + NS_ADDREF(*topWinRet = topWinInt); return true; } -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
