LGTM with a couple of questions.

http://gwt-code-reviews.appspot.com/119803/diff/1/2
File user/src/com/google/gwt/core/client/Scheduler.java (right):

http://gwt-code-reviews.appspot.com/119803/diff/1/2#newcode70
Line 70: unimplemented();
Is it better to have this fail at runtime than to require people to
update their custom schedulers (by making these abstract)?

http://gwt-code-reviews.appspot.com/119803/diff/1/7
File user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java
(right):

http://gwt-code-reviews.appspot.com/119803/diff/1/7#newcode87
Line 87: @DoNotRunWith(Platform.HtmlUnit)
Would it be useful to add a comment explaining why HtmlUnit can't be
used?  Otherwise, it will be hard to know when this should be removed.
Likewise with the others.

http://gwt-code-reviews.appspot.com/119803

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to