Reviewers: bobv, Description: Some servlet containers throw an NPE on servlet.log(message, (Throwable) null) Since the spec doesn't really say what should happen in this case, we should call servlet.log(message) instead, just to be safe.
Please review this at http://gwt-code-reviews.appspot.com/126809 Affected files: user/src/com/google/gwt/user/server/rpc/HybridServiceServlet.java user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java Index: user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java =================================================================== --- user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java (revision 7325) +++ user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java (working copy) @@ -71,7 +71,7 @@ + ", is not in the same web application as this servlet, " + contextPath + ". Your module may not be properly configured or your client and server code maybe out of date."; - servlet.log(message, null); + servlet.log(message); } else { // Strip off the context path from the module base URL. It should be a // strict prefix. @@ -146,8 +146,7 @@ + strongName + "' for module '" + moduleBaseURL - + "'; a legacy, 1.3.3 compatible, serialization policy will be used. You may experience SerializationExceptions as a result.", - null); + + "'; a legacy, 1.3.3 compatible, serialization policy will be used. You may experience SerializationExceptions as a result."); serializationPolicy = RPC.getDefaultSerializationPolicy(); } Index: user/src/com/google/gwt/user/server/rpc/HybridServiceServlet.java =================================================================== --- user/src/com/google/gwt/user/server/rpc/HybridServiceServlet.java (revision 7325) +++ user/src/com/google/gwt/user/server/rpc/HybridServiceServlet.java (working copy) @@ -86,8 +86,7 @@ + strongName + "' for module '" + moduleBaseURL - + "'; a legacy, 1.3.3 compatible, serialization policy will be used. You may experience SerializationExceptions as a result.", - null); + + "'; a legacy, 1.3.3 compatible, serialization policy will be used. You may experience SerializationExceptions as a result."); serializationPolicy = RPC.getDefaultSerializationPolicy(); } -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
