Wearing my "nitpicker" hat ;-) How about replacing the VerticalPanel and HorizontalPanel with FlowPanels too? (replace the HTML() label with InlineHTML() to make it show on the same line as the ListBox and Button) Or even use UiBinder to create the UI? (people might look at "reference" applications as examples or even best-practices)
http://gwt-code-reviews.appspot.com/127801/diff/1101/1102 File reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/Microbenchmarks.gwt.xml (right): http://gwt-code-reviews.appspot.com/127801/diff/1101/1102#newcode2 Line 2: <!DOCTYPE module PUBLIC "-//Google Inc.//DTD Google Web Toolkit 0.0.999//EN" "http://google-web-toolkit.googlecode.com/svn/tags/0.0.999/distro-source/core/src/gwt-module.dtd";> 0.0.999 ? Better remove the DOCTYPE altogether, no? http://gwt-code-reviews.appspot.com/127801/diff/1101/1106 File reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/Microbenchmarks.java (right): http://gwt-code-reviews.appspot.com/127801/diff/1101/1106#newcode59 Line 59: horizontalPanel.remove(runningLabel); runningLabel probably won't ever be visible in this synchronous scenario. How about moving the run() and remove(runningLabel) in a DeferredCommand? http://gwt-code-reviews.appspot.com/127801/diff/1101/1108 File reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestDom.java (right): http://gwt-code-reviews.appspot.com/127801/diff/1101/1108#newcode38 Line 38: private static final DivElement detachedDiv = Document.get().createDivElement(); Isn't this creating a clinit, when accessing TestDom.HTML from other widgets (e.g. TestCursorDomCrawl). Shouldn't make much of a difference on the benchmark results but still... http://gwt-code-reviews.appspot.com/127801/diff/1101/1117 File reference/Microbenchmarks/war/Microbenchmarks.html (right): http://gwt-code-reviews.appspot.com/127801/diff/1101/1117#newcode1 Line 1: <!DOCTYPE> Er, you probably rather meant <!DOCTYPE html> ? http://gwt-code-reviews.appspot.com/127801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
