On 2010/01/06 17:30:23, scottb wrote:
LG, but one thing is bothering me...

Shouldn't you be able to rip out a bunch of old code now?  Since we're
always
collecting param names, shouldn't all that "argNamesAreReal" mess go
away?

It will be needed when we implement the second phase of IHM, where we
actually run from .class files if they exist.  We will still need to be
able to handle the case where the preprocessing was not done (such as
when editing the source in Eclipse, it will update the compiled class
file but it may not be possible to have our preprocessor run
automatically in that case).  So, we will need the ability to go fetch
the source if necessary.

http://gwt-code-reviews.appspot.com/129802/diff/1/16#newcode336
Line 336: allMethodArgs.put(entry.getKey(), entry.getValue());
Can't you just putAll() the whole map?

Yes, thanks.

http://gwt-code-reviews.appspot.com/129802
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to