Take Ray's line of thinking one step further and have three methods? setAutoHideOnClick() setAutoHideOnHistory() setAutoHide() // Both of the above and any auto-hide-ish conditions identified later
The constructor arg is passed to setAutoHide(). That makes sense in my head. Is that more confusing to anyone else? On Wed, Jan 13, 2010 at 4:08 PM, John LaBanca <[email protected]> wrote: >> So keep the new property, and set it true as a side effect of new > > Will it be confusing that it is a side effect of the constructor but not of > setAutoHide()? Also, is it worth breaking existing code if we are providing > a separate method anyway? I actually agree that its a good idea because its > better for most users, but I'm just playing devil's advocate here. Let me > know what you think and I'll prepare a final patch. >> >> Also, I don't think you need "enabled" in that property name. > > I can remove it. > Thanks, > John LaBanca > [email protected] > > > On Wed, Jan 13, 2010 at 4:03 PM, <[email protected]> wrote: >> >> On Wed, Jan 13, 2010 at 12:55 PM, Isaac Truett <[email protected]> >> wrote: >>> >>> I like it except for one scenario: >> >>> Say I have a GWT-powered eBook reader. I hide some navigation controls >>> in the corner; mouse over and they pop up. I want them to disappear if >>> you click outside the popup, so auto-hide=true. But If you click "next >>> page" I want to set a history token (for the next page) and I want the >>> controls to stay visible so that you don't have to mouse back over the >>> trigger in the corner in order to flip the page again, or flip back. >>> If auto-hide-on-click implied auto-hide-on-history then you would have >>> to jump through some more hoops (keep track of the popup state and >>> re-show after history change if it was visible before). >> >> So keep the new property, and set it true as a side effect of new >> PopupPanel(true). For Isaac's eReader: >> >> PopupPanel panel = new PopupPanel(true); >> panel.setAutoHideOnHistoryEventsEnabled(false); >> >> Also, I don't think you need "enabled" in that property name. >> >> http://gwt-code-reviews.appspot.com/132804 > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors >
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
