Revision: 7394
Author: [email protected]
Date: Wed Jan 13 14:01:33 2010
Log: Misc formatting / checkstyle fixes.
http://code.google.com/p/google-web-toolkit/source/detail?r=7394
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java
/trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java
/trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
/trunk/eclipse/user/.checkstyle
/trunk/user/src/com/google/gwt/layout/client/LayoutImplIE6.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/IntPairParser.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/StrictAttributeParser.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
/trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java
/trunk/user/test/com/google/gwt/emultest/java/util/ListTestBase.java
/trunk/user/test/com/google/gwt/uibinder/UiBinderJreSuite.java
/trunk/user/test/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverterTest.java
/trunk/user/test/com/google/gwt/uibinder/test/client/ParameterizedWidgets.java
/trunk/user/test/com/google/gwt/user/client/rpc/UnicodeEscapingService.java
=======================================
---
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
Mon Dec 21 06:55:18 2009
+++
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
Wed Jan 13 14:01:33 2010
@@ -56,7 +56,7 @@
}
/**
- * Returns the hexadecimal representation of a character
+ * Returns the hexadecimal representation of a character.
*/
public static StringBuilder charToHex(char c) {
char hexDigit[] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
@@ -105,19 +105,15 @@
if ((c[i] < '\u0020')) {
builder.append(c, lastIndex, i - lastIndex);
if (c[i] == '\u0000') {
- builder.append("\\0");
- }
- else if (c[i] == '\u0009') {
- builder.append("\\t");
- }
- else if (c[i] == '\n') {
- builder.append("\\n");
- }
- else if (c[i] == '\r') {
- builder.append("\\r");
- }
- else {
- builder.append("(invalid xml character: \\u" + charToHex(c[i])
+ ")");
+ builder.append("\\0");
+ } else if (c[i] == '\u0009') {
+ builder.append("\\t");
+ } else if (c[i] == '\n') {
+ builder.append("\\n");
+ } else if (c[i] == '\r') {
+ builder.append("\\r");
+ } else {
+ builder.append("(invalid xml character: \\u" + charToHex(c[i])
+ ")");
}
lastIndex = i + 1;
} else if (((c[i] >= '\u007F') && (c[i] <= '\u0084')) ||
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java Fri Nov 6
13:40:11 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java Wed Jan 13
14:01:33 2010
@@ -220,7 +220,7 @@
}
/**
- * NOTE: not called from JsniFieldRef
+ * NOTE: not called from JsniFieldRef.
*/
public void endVisit(JFieldRef x, Context ctx) {
endVisit((JVariableRef) x, ctx);
@@ -287,7 +287,7 @@
}
/**
- * NOTE: not called from JsniMethodRef
+ * NOTE: not called from JsniMethodRef.
*/
public void endVisit(JMethodCall x, Context ctx) {
endVisit((JExpression) x, ctx);
@@ -528,7 +528,7 @@
}
/**
- * NOTE: not called from JsniFieldRef
+ * NOTE: not called from JsniFieldRef.
*/
public boolean visit(JFieldRef x, Context ctx) {
return visit((JVariableRef) x, ctx);
@@ -595,7 +595,7 @@
}
/**
- * NOTE: not called from JsniMethodRef
+ * NOTE: not called from JsniMethodRef.
*/
public boolean visit(JMethodCall x, Context ctx) {
return visit((JExpression) x, ctx);
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java Mon
Nov 23 16:21:36 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java Wed
Jan 13 14:01:33 2010
@@ -1473,7 +1473,7 @@
}
/**
- * The current version of the protocol
+ * The current version of the protocol.
*/
public static final int PROTOCOL_VERSION_CURRENT = 3;
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Sun Nov 29 20:11:12 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Wed Jan 13 14:01:33 2010
@@ -246,7 +246,6 @@
* The mask to use for Ctrl -- mapped to Command on Mac.
*/
private static int ctrlKeyDown;
-
private static final Color DISCONNECTED_COLOR = Color.decode("0xFFDDDD");
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java
Mon Nov 23 21:20:12 2009
+++
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java
Wed Jan 13 14:01:33 2010
@@ -92,14 +92,14 @@
/**
* Add a log entry.
*
+ * @param indexOfLogEntryWithinParentLogger The index of this entry
within the
+ * parent logger
* @param type The severity of the log message.
* @param msg The message.
* @param caught An exception associated with the message
* @param helpInfo A URL or message which directs the user to helpful
* information related to the log message
* @param logHandle The log handle of the parent of this log entry/branch
- * @param indexOfLogentryWithinParentLogger The index of this entry
within the
- * parent logger
*/
public void addLogEntry(int indexOfLogEntryWithinParentLogger, Type type,
String msg, Throwable caught, HelpInfo helpInfo, int logHandle) {
=======================================
--- /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Mon Dec 21 06:55:18 2009
+++ /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Wed Jan 13 14:01:33 2010
@@ -132,7 +132,7 @@
+ "-index.html\">Permutation " + permutationId);
if (permutationInfoList.size() > 0) {
for (String desc : permutationInfoList) {
- outFile.println(" (" + desc + ")" );
+ outFile.println(" (" + desc + ")");
}
outFile.println("</a></li>");
} else {
=======================================
--- /trunk/eclipse/user/.checkstyle Fri May 25 08:55:58 2007
+++ /trunk/eclipse/user/.checkstyle Wed Jan 13 14:01:33 2010
@@ -4,8 +4,8 @@
<file-match-pattern match-pattern=".*src.*\.java"
include-pattern="true"/>
</fileset>
<fileset name="Java source for test cases" enabled="true"
check-config-name="GWT Checks for Tests" local="false">
- <file-match-pattern
match-pattern=".*test.*com[/\\]google[/\\].*\.java$"
include-pattern="true"/>
- <file-match-pattern match-pattern=".*test.*test[/\\].*\.java$"
include-pattern="true"/>
+ <file-match-pattern
match-pattern="core[/\\]test[/\\]com[/\\]google[/\\].*\.java$"
include-pattern="true"/>
+ <file-match-pattern
match-pattern="core[/\\]test[/\\]test[/\\].*\.java$"
include-pattern="true"/>
</fileset>
<filter name="NonSrcDirs" enabled="true"/>
</fileset-config>
=======================================
--- /trunk/user/src/com/google/gwt/layout/client/LayoutImplIE6.java Tue Nov
10 10:16:43 2009
+++ /trunk/user/src/com/google/gwt/layout/client/LayoutImplIE6.java Wed Jan
13 14:01:33 2010
@@ -285,7 +285,6 @@
ruler.onresize = null;
}-*/;
-
@SuppressWarnings("unused") // called from JSNI
private void resizeHandler(Element parent) {
resizeHandler(parent, false);
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java
Thu Nov 19 12:57:33 2009
+++
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java
Wed Jan 13 14:01:33 2010
@@ -26,7 +26,7 @@
import java.util.Map;
/**
- * Managers access to all implementations of {...@link AttributeParser}
+ * Managers access to all implementations of {...@link AttributeParser}.
*/
public class AttributeParsers {
private static final String VERT_CONSTANT
= "com.google.gwt.user.client.ui.HasVerticalAlignment."
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
Mon Nov 16 15:06:51 2009
+++
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
Wed Jan 13 14:01:33 2010
@@ -109,7 +109,6 @@
private static final Pattern BRACES = Pattern.compile("[{]([^}]*)[}]");
private static final Pattern LEGAL_FIRST_CHAR =
Pattern.compile("^[$_a-zA-Z].*");
-
/**
* @return true if the given string holds one or more field references
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/IntPairParser.java
Wed Nov 11 22:08:47 2009
+++
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/IntPairParser.java
Wed Jan 13 14:01:33 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.uibinder.attributeparsers;
-
/**
* Parses a pair of integer values.
*/
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/StrictAttributeParser.java
Wed Nov 25 09:15:38 2009
+++
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/StrictAttributeParser.java
Wed Jan 13 14:01:33 2010
@@ -27,7 +27,7 @@
class StrictAttributeParser implements AttributeParser {
/**
- * Package protected for testing
+ * Package protected for testing.
*/
static class FieldReferenceDelegate implements Delegate {
private boolean sawReference = false;
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
Wed Dec 2 10:02:31 2009
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
Wed Jan 13 14:01:33 2010
@@ -22,7 +22,7 @@
import com.google.gwt.user.client.ui.DialogBox;
/**
- * Parses {...@link DialogBox} widgets
+ * Parses {...@link DialogBox} widgets.
*/
public class DialogBoxParser implements ElementParser {
public void parse(XMLElement elem, String fieldName, JClassType type,
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java Wed Nov
25 09:15:38 2009
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java Wed Jan
13 14:01:33 2010
@@ -148,7 +148,7 @@
}
/**
- * Ensure that the receiver has no attributes left
+ * Ensure that the receiver has no attributes left.
*
* @throws UnableToCompleteException if it does
*/
@@ -169,7 +169,7 @@
}
/**
- * Require that the receiver's body is empty of text and has no child
nodes
+ * Require that the receiver's body is empty of text and has no child
nodes.
*
* @throws UnableToCompleteException if it isn't
*/
@@ -185,7 +185,7 @@
}
/**
- * Require that the receiver's body is empty of text
+ * Require that the receiver's body is empty of text.
*
* @throws UnableToCompleteException if it isn't
*/
@@ -203,7 +203,7 @@
* parameter is required to determine how the value is parsed and
validated.
*
* @param name the attribute's full name (including prefix)
- * @param types the type(s) this attribute is expected to provide
+ * @param type the type this attribute is expected to provide
* @return the attribute's value as a Java expression, or null if it is
not set
* @throws UnableToCompleteException on parse failure
*/
@@ -218,7 +218,7 @@
*
* @param name the attribute's full name (including prefix)
* @param defaultValue the value to @return if the attribute was unset
- * @param types the type(s) this attribute is expected to provide
+ * @param type the type this attribute is expected to provide
* @return the attribute's value as a Java expression, or the given
default if
* it was unset
* @throws UnableToCompleteException on parse failure
@@ -301,7 +301,7 @@
}
/**
- * Consumes and returns all child elements
+ * Consumes and returns all child elements.
*
* @throws UnableToCompleteException if extra text nodes are found
*/
@@ -475,7 +475,6 @@
* (or a mix of both).
*
* @return array of String, empty if the attribute was not set.
- * @throws UnableToCompleteException on unparseable value
*/
public String[] consumeRawArrayAttribute(String name) {
String raw = consumeRawAttribute(name, null);
=======================================
--- /trunk/user/test/com/google/gwt/emultest/java/util/ListTestBase.java
Wed Dec 9 10:59:15 2009
+++ /trunk/user/test/com/google/gwt/emultest/java/util/ListTestBase.java
Wed Jan 13 14:01:33 2010
@@ -23,7 +23,6 @@
import java.util.List;
import java.util.ListIterator;
-
/**
* Tests List, and, by extension AbstractList. Uses inheritance to inherit
all
* of Apache's TestList and TestCollection.
=======================================
--- /trunk/user/test/com/google/gwt/uibinder/UiBinderJreSuite.java Fri Nov
20 13:09:39 2009
+++ /trunk/user/test/com/google/gwt/uibinder/UiBinderJreSuite.java Wed Jan
13 14:01:33 2010
@@ -41,7 +41,7 @@
import junit.framework.TestSuite;
/**
- * Suite of UiBinder tests that require the JRE
+ * Suite of UiBinder tests that require the JRE.
*/
public class UiBinderJreSuite {
public static Test suite() {
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverterTest.java
Mon Nov 16 15:06:51 2009
+++
/trunk/user/test/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverterTest.java
Wed Jan 13 14:01:33 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.uibinder.attributeparsers;
-
import com.google.gwt.core.ext.typeinfo.JType;
import junit.framework.TestCase;
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/test/client/ParameterizedWidgets.java
Thu Nov 19 13:38:23 2009
+++
/trunk/user/test/com/google/gwt/uibinder/test/client/ParameterizedWidgets.java
Wed Jan 13 14:01:33 2010
@@ -22,7 +22,7 @@
import com.google.gwt.user.client.ui.Widget;
/**
- * Used by {...@link TestParameterizedWidgets}
+ * Used by {...@link TestParameterizedWidgets}.
*/
class ParameterizedWidgets {
interface Binder extends UiBinder<Widget, ParameterizedWidgets> {
=======================================
---
/trunk/user/test/com/google/gwt/user/client/rpc/UnicodeEscapingService.java
Tue Oct 28 11:27:54 2008
+++
/trunk/user/test/com/google/gwt/user/client/rpc/UnicodeEscapingService.java
Wed Jan 13 14:01:33 2010
@@ -75,13 +75,14 @@
* Verifies that the string contains the specified characters.
*
* Used to verify client->server escaping.
- *
+ *
* @param start start code point value included
* @param end first code point not included
* @param str string to verify
- * @throws InvalidCharacterException if the string does not contain the
specified characters
+ * @throws UnicodeEscapingService.InvalidCharacterException if the
string does
+ * not contain the specified characters
* @return true if the verification succeeded
*/
boolean verifyStringContainingCharacterRange(int start, int end, String
str)
- throws InvalidCharacterException;
-}
+ throws UnicodeEscapingService.InvalidCharacterException;
+}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
