I'll try to provided an updated patch asap (I have no devenv at hand right now) In the mean time, you can still comment on http://gwt-code-reviews.appspot.com/88802/patch/1/4 ;-)
BTW, thanks for looking into it again! http://gwt-code-reviews.appspot.com/88802/diff/1/6 File user/test/com/google/gwt/http/client/URLTest.java (right): http://gwt-code-reviews.appspot.com/88802/diff/1/6#newcode237 Line 237: assertEquals("%20", URL.encodePathSegment(" ")); On 2010/01/13 21:18:46, Ray Ryan wrote:
Shouldn't you test that + is not encoded?
Per ECMAScript, + will be encoded; and what matters here is that whether it's a + or a %2B, it's treated as a "+" when decoded (i.e. by the server in this case). If you really want +'es not to be encoded, you're free to add an extra step replacing %2B with +. http://gwt-code-reviews.appspot.com/88802/diff/1/6#newcode256 Line 256: assertEquals("+", URL.encodeQueryString(" ")); On 2010/01/13 21:18:46, Ray Ryan wrote:
ditto for %20
Again, %20 will be encoded, though for other reasons, as %2520. http://gwt-code-reviews.appspot.com/88802
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
