LGTM

http://gwt-code-reviews.appspot.com/130808/diff/7/9
File
user/src/com/google/gwt/resources/rebind/context/InlineResourceContext.java
(right):

http://gwt-code-reviews.appspot.com/130808/diff/7/9#newcode27
Line 27: public static final int MAX_ENCODED_SIZE = (2 << 15) - 1;
I had no idea. I don't suppose this is defined in a system property or
something?

http://gwt-code-reviews.appspot.com/130808/diff/7/10
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/130808/diff/7/10#newcode716
Line 716: if (child2.getLocalName().equalsIgnoreCase("lossless")) {
So if lossless isn't specified, it's lossy? Or is that ambiguous? You're
confident pngs and gifs will have this set? Guess your unit tests cover
that.

http://gwt-code-reviews.appspot.com/130808
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to