On 2010/01/21 16:20:28, Ray Ryan wrote:
LGTM
A nit and a question, but you're good to go
http://gwt-code-reviews.appspot.com/130817/diff/1/3
File user/src/com/google/gwt/resources/css/GenerateCssAst.java
(right):
http://gwt-code-reviews.appspot.com/130817/diff/1/3#newcode239
Line 239: public void ignorableAtRule(String atRule) throws
CSSException {
method name seems strange. You're processing the atRule, and you might
ignore
it. Or did I misread?
The interface that defines this method comes from the SAC API. The
semantics of a random at-rule in CSS is that a conforming user agent may
ignore at-rules that it is unable to process.
http://gwt-code-reviews.appspot.com/130817/diff/1/3#newcode248
Line 248: + ruleName.substring(1).toLowerCase();
Really? You never camel case? You sure you want to be so forgiving of
case
errors?
CSS is supposed to be case-insensitive, it makes sense to be lenient
here.
http://gwt-code-reviews.appspot.com/130817/diff/1/10
File user/test/com/google/gwt/resources/css/unknownAtRule.css (right):
http://gwt-code-reviews.appspot.com/130817/diff/1/10#newcode7
Line 7: /* This should be dropped */
why?
Comments are eliminated by the tokenizer and aren't a production in the
grammar.
http://gwt-code-reviews.appspot.com/130817
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
