On 2010/01/22 16:08:39, jlabanca wrote:
LGTM

http://gwt-code-reviews.appspot.com/132817/diff/2001/23
File user/test/com/google/gwt/user/client/ui/SplitLayoutPanelTest.java
(right):

http://gwt-code-reviews.appspot.com/132817/diff/2001/23#newcode92
Line 92: assertEquals(l1, children.get(2));
DockLayoutPanel.getWidget(1) is going to return the HSplitter.  That
seems
wrong, its should return the second widget that was added.

This is a separate issue from this patch, but I think its still an
issue.

That's a reasonable, if arguable, point. I agree that it's a separate
issue, though.

Committed at r7444.

http://gwt-code-reviews.appspot.com/132817

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to