On Fri, Feb 5, 2010 at 10:23 AM, John Tamplin <[email protected]> wrote: > On Fri, Feb 5, 2010 at 10:05 AM, James Laska <[email protected]> wrote: >> >> You noted that the modified libraries are documented, I gather this is >> in the README file in the same directory? Looking in 'tools/lib' for >> README files I see the following special handling instructions: >> >> * gwt-2.0.0/tools/lib/protobuf/protobuf-2.2.0/README >> * gwt-2.0.0/tools/lib/htmlunit/README >> >> Are there others to consider? >> >> Have the local library modifications been sent/accepted in the upstream >> project? > > I know they have in the case of HtmlUnit, though I have no idea if they have > been accepted. Amit Manjhi ([email protected]) would be the one to talk > to about HtmlUnit changes. I don't know about others. > >> >> Oh good to know. This shouldn't be too much trouble. I can have GWT >> %buildrequire a specific version of a library. If newer versions of >> that library are available, I should be able to provide the older >> library as a compatibility. >> >> Perhaps the same question as earler, is there a way to tell when GWT >> requires a *specific* library version? Or should I default to using >> the latest, and see where the build fails? > > Hopefully our tests are sufficient that an incompatible version would fail > tests, so I would try the newest version first.
Great, I'll proceed that way first. > The build files would likely need some hacking -- right now, it expects to > find everything in tools under ../tools or $(GWT_TOOLS), not individually > located. You could have the spec file apply a patch against it, or if the > changes could be done such that the default behavior worked as it does now > but supplying -D flags to ant overrode the locations I think we could make > those changes directly in GWT. The strategy I've been following, as recommended by other Fedora java packaging gurus, is to add logic during the %prep step in the spec file that removes bundled JAR files and replaces them with symlinks to the system versions. This seems to be progressing well so far, and requires no downstream patching of GWT. For more details ... http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software Thanks, James -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
