Reviewers: jgw,

Description:
When the History iframe is absent, History is disabled in IE and impl
will be set to null.  Using some of the methods in History will result
in an NPE, only in IE.

This affects PopupPanel, which adds a history handler automatically and
throws an NPE in IE if the History iframe is not present.

Fix:
====
We now do a null check in all methods in History to ensure that impl is
not null.  We already did this on some methods, but not all.

Testing:
=======
I created a junit test to ensure that disabling History does not result
in any errors.

Please review this at http://gwt-code-reviews.appspot.com/138805

Affected files:
  user/src/com/google/gwt/user/client/History.java
  user/test/com/google/gwt/user/HistoryDisabledTest.gwt.xml
  user/test/com/google/gwt/user/UISuite.java
  user/test/com/google/gwt/user/client/HistoryDisabledTest.java
  user/test/com/google/gwt/user/client/impl/HistoryImplDisabled.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to