Reviewers: jlabanca,

Description:
See
http://groups.google.fr/group/Google-Web-Toolkit-Contributors/t/e705905e2cc78408

This patch:
 - fixes NativeEvent::getKeyCode so it always returns e.keyCode
 - introduces NativeEvent::getCharCode to return (e.keyCode ||
e.charCode) as suggested by PPK (this means getKeyCode is only "valid"
within KeyCode events, while getCharCode is only "valid" within KeyPress
events, which is exactly the current state of affairs, says PPK, and I
tend to trust him on this point). I didn't even tried to use deferred
binding here to use either one or the other, just because I do not have
time to research which one to use in which browser.
 - introduces KeyPressEvent::getNativeCharCode to return an 'int' in the
event that a character outside the Unicode BMP is pressed, because in
Java, a 'char' is 16 bits (I haven't been able to produce such an event,
I don't know if it's a limitation of Windows XP or the browsers, I
tested in Firefox 3.6 and Chrome 5 dev)

This fixes issue 3753, though it doesn't attempt at solving issues 72
and 1529 (GWT to suppress KeyPressEvents for non-printable chars)

Please review this at http://gwt-code-reviews.appspot.com/142801

Affected files:
  user/src/com/google/gwt/dom/client/DOMImpl.java
  user/src/com/google/gwt/dom/client/NativeEvent.java
  user/src/com/google/gwt/event/dom/client/KeyPressEvent.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to