LGTM

Just verify that you added the call to isMyListener() because the
listener could be used by a different module.


http://gwt-code-reviews.appspot.com/139801/diff/1/2
File user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImpl.java
(right):

http://gwt-code-reviews.appspot.com/139801/diff/1/2#newcode88
Line 88: this.owner = richTextWidget;
You can call setOwner(richTextWidget) instead.

Add JavaDoc:
/**
 * @deprecated as of GWT 2.1, use {...@link
setOwner(HasInitializeHandlers)} instead
 */

http://gwt-code-reviews.appspot.com/139801/diff/1/3
File
user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
(right):

http://gwt-code-reviews.appspot.com/139801/diff/1/3#newcode96
Line 96: if
(@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(elem.__listener))
{
Why is this needed again?  Is it possible that the listener is in a
different module?

http://gwt-code-reviews.appspot.com/139801

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to