Revision: 7639
Author: [email protected]
Date: Mon Mar 1 10:57:15 2010
Log: Rolling back r7635 because this is causing unexpected failures on
Firefox,
which I will look at tomorrow morning.
Review at http://gwt-code-reviews.appspot.com/153815
http://code.google.com/p/google-web-toolkit/source/detail?r=7639
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java
/trunk/user/test/com/google/gwt/user/client/ui/TextBoxTest.java
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java Mon Mar
1 09:49:01 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java Mon Mar
1 10:57:15 2010
@@ -272,8 +272,7 @@
// any calls made to FocusWidget.setTabIndex(int) by user code, because
// FocusWidget.setTabIndex(int) cannot be called until setElement(elem)
// has been called.
- if (-1 == getTabIndex()) {
- setTabIndex(0);
- }
- }
-}
+ setTabIndex(0);
+ }
+
+}
=======================================
--- /trunk/user/test/com/google/gwt/user/client/ui/TextBoxTest.java Mon
Mar 1 09:49:01 2010
+++ /trunk/user/test/com/google/gwt/user/client/ui/TextBoxTest.java Mon
Mar 1 10:57:15 2010
@@ -15,9 +15,6 @@
*/
package com.google.gwt.user.client.ui;
-import com.google.gwt.dom.client.DivElement;
-import com.google.gwt.dom.client.Document;
-
/**
* Testing TextBox.
*/
@@ -35,7 +32,7 @@
// As our setText does not honor max length, no way to text it in the
wild
// here.
}
-
+
public void testMinLength() {
TextBox b = createTextBoxBase();
b.setVisibleLength(5);
@@ -47,14 +44,4 @@
// Now check visible length.
assertEquals(5, b.getVisibleLength());
}
-
- public void testNoNukeTabIndex() {
- Document doc = Document.get();
- DivElement div = doc.createDivElement();
- div.setInnerHTML("<input type='text' id='tb' tabindex='1'></input>");
- doc.getBody().appendChild(div);
-
- TextBox tb = TextBox.wrap(doc.getElementById("tb"));
- assertEquals(1, tb.getTabIndex());
- }
-}
+}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors