http://gwt-code-reviews.appspot.com/150801/diff/1/5 File dev/core/src/com/google/gwt/dev/cfg/Condition.java (right):
http://gwt-code-reviews.appspot.com/150801/diff/1/5#newcode44 Line 44: public final boolean isTrue(TreeLogger logger, PropertyOracle propertyOracle, Could you collapse the parameters for isTrue() and doEval() into a BagOfStuffThatAffectsEvaluation object? That way, the next new Condition type won't lead to more and more parameters on this method. http://gwt-code-reviews.appspot.com/150801/diff/1/14 File dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java (right): http://gwt-code-reviews.appspot.com/150801/diff/1/14#newcode913 Line 913: protected Schema __when_linker_added_begin(String linkerName) { The parameter should be a LinkerName type. http://gwt-code-reviews.appspot.com/150801/diff/1/15 File dev/core/src/com/google/gwt/dev/cfg/Properties.java (right): http://gwt-code-reviews.appspot.com/150801/diff/1/15#newcode83 Line 83: public int numPermutations(Set<String> activeLinkerNames) { This seems wrong. Why should a property matrix care about the linkers? Wouldn't it be better to update the callers of this method to call through PropertyPermutations instead? http://gwt-code-reviews.appspot.com/150801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
