LGTM

http://gwt-code-reviews.appspot.com/159810/diff/1/2
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):

http://gwt-code-reviews.appspot.com/159810/diff/1/2#newcode200
Line 200: }
Clever. I like it.

http://gwt-code-reviews.appspot.com/159810/diff/1/3
File dev/core/src/com/google/gwt/core/linker/XSTemplate.js (left):

http://gwt-code-reviews.appspot.com/159810/diff/1/3#oldcode291
Line 291: processMetas();
On 2010/03/08 17:25:52, Lex wrote:
This ordering is necessary because the meta props now affect the base
URL.  I
couldn't think of any way the other ordering would be necessary.

I'm pretty sure this reordering is fine.

http://gwt-code-reviews.appspot.com/159810

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to