LGTM with nits.  Thanks for doing this!

http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):

http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode285
Line 285: return (int) (time ^ (getTime() >>> 32));
'getTime()' can be changed to 'time'

http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode343
Line 343: String hourOffset = (offset >= 0) ? "+" : "" + (offset / 60);
Parens around the ?: expression would be nice

http://gwt-code-reviews.appspot.com/181801

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to