LGTM.

Really, though, we should remove FragmentLoaderCreator.



http://gwt-code-reviews.appspot.com/159811/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java
(left):

http://gwt-code-reviews.appspot.com/159811/diff/1/2#oldcode114
Line 114: private void generateOnErrorMethod(PrintWriter srcWriter) {
No, it looks stale.

http://gwt-code-reviews.appspot.com/159811/diff/1/4
File user/src/com/google/gwt/core/client/prefetch/Prefetcher.java
(right):

http://gwt-code-reviews.appspot.com/159811/diff/1/4#newcode33
Line 33: public static void prefetch(Collection<? extends
PrefetchableResource> resources) {
I believe you meant new int[0].  I guess this is an improvement, given
that ArrayList<Integer> is heavier than int[] right now.

http://gwt-code-reviews.appspot.com/159811

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to