Thank you for the feedback.
> It was trivial to hook up the findClientOracleData to work with the existing
> process
Excellent.
> - NPE in the WebModeClientOracle.readStreamAsObject finally block if
> objectInputStream can't be created (ie: if the format is invalid)
Will fix.
> - If the GWT module base path URL isn't absolute, getRequestModuleBasePath
> fails. We use relative base paths to simplify our hosted mode development.
Can you describe this setup in more detail? What is the canonical URL
that the request's url should be evaluated against?
> - WebModePayloadSink seems to throw an NPE when push a null
> constructorIdent. I'm still digging into this, but it might be related to the
> fact that we're sending enums with enum value methods across the wire:
The code that you posted is about creating a payload for a object that
has custom serialization. What does looking at the fields of the
InvokeCustomFieldSerializerCommand object show?
> RpcServlet is much nicer to work with that RemoveServiceServlet, kudos. It
> would be nice if the service object (passed into decodeRequest and
> invokeAndStreamResponse) were retrieved via a protected method, rather than
> assumed to be 'this'. We wire the service object into the servlet at
> configuration time via Spring, so I had to duplicate the contents of
> processCall.
How about a
protected Object getRequestTargetObject() {
return this;
}
?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
