From desk review w/Amit. Will do this and some other cleanup and then submit:
Revert Places.java Maybe todo valuestore in EmployeeListRequest as not-used-yet Try to back out ValueStore changes since they do nothing yet http://gwt-code-reviews.appspot.com/243801/diff/6001/7001 File bikeshed/src/com/google/gwt/requestfactory/client/EntityListRequestImpl.java (right): http://gwt-code-reviews.appspot.com/243801/diff/6001/7001#newcode32 bikeshed/src/com/google/gwt/requestfactory/client/EntityListRequestImpl.java:32: public class EntityListRequestImpl<E> implements EntityListRequest<E> { Not yet used, save for next patch. http://gwt-code-reviews.appspot.com/243801/diff/6001/7002 File bikeshed/src/com/google/gwt/requestfactory/shared/EntityKey.java (right): http://gwt-code-reviews.appspot.com/243801/diff/6001/7002#newcode28 bikeshed/src/com/google/gwt/requestfactory/shared/EntityKey.java:28: * @return Real doc http://gwt-code-reviews.appspot.com/243801/diff/6001/7015 File bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityListPlace.java (left): http://gwt-code-reviews.appspot.com/243801/diff/6001/7015#oldcode22 bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityListPlace.java:22: public class EntityListPlace extends ExpensesScaffoldPlace { Undelete the visitor mechanism and the other places. Patch is too big, will probably still need them. http://gwt-code-reviews.appspot.com/243801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
