LGTM except for two URLs being changed.

http://gwt-code-reviews.appspot.com/258801/diff/1/21
File user/test/com/google/gwt/regexp/shared/RegExpTest.java (right):

http://gwt-code-reviews.appspot.com/258801/diff/1/21#newcode533
user/test/com/google/gwt/regexp/shared/RegExpTest.java:533: *
https://sourceforge.net/tracker/?func=detail&aid=2949446&group_id=47038&atid=448266.
I would rather not add the . on the end of the URL.  Instead, how about
change the colon to period above, and make this line be "See <url>"

http://gwt-code-reviews.appspot.com/258801/diff/1/24
File user/test/com/google/gwt/user/client/ui/AbsolutePanelTest.java
(right):

http://gwt-code-reviews.appspot.com/258801/diff/1/24#newcode43
user/test/com/google/gwt/user/client/ui/AbsolutePanelTest.java:43: *
https://sourceforge.net/tracker/?func=detail&aid=2892289&group_id=47038&atid=448266.
Likewise here.

http://gwt-code-reviews.appspot.com/258801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words "REMOVE ME" as the subject.

Reply via email to