Reviewers: mmendez,

Description:
RunStyleSelenium uses Selenium.getTitle() as a keep alive to check that
the GWT host can communicate with the selenium server running on the
client.  However, getTitle() sometimes returns a Permision Denied
SeleniumException in IE if we happen to request the title while the page
is transitioning to a new module.

Also, we use one thread to check keep alives, and another for shutdown.
Our keep alive thread often runs while we are shutting down, which
results in a harmless but visible ERROR on the selenium server console.

Fix:
====
This patch ignores permission denied errors.  It also adds a thread lock
object to ensure that once the shutdown thread is activated, the keep
alive thread stops running.


Testing:
========
Manually ran unit tests multiple times and verified that the IE
permission denied error no longer fails the tests, and that we no longer
see random errors in the selenium console.

Please review this at http://gwt-code-reviews.appspot.com/264801/show

Affected files:
  user/src/com/google/gwt/junit/RunStyleSelenium.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words "REMOVE ME" as the subject.

Reply via email to