Notes from a desk review w/Amit. Will make these changes and commit
http://gwt-code-reviews.appspot.com/251801/diff/8001/9001 File bikeshed/src/com/google/gwt/app/place/GoToPlace.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9001#newcode25 bikeshed/src/com/google/gwt/app/place/GoToPlace.java:25: public class GoToPlace<P extends Place> implements Command { GoToPlaceCommand Similarly, *Presenter on the presenters. http://gwt-code-reviews.appspot.com/251801/diff/8001/9002 File bikeshed/src/com/google/gwt/app/place/PlacePicker.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9002#newcode35 bikeshed/src/com/google/gwt/app/place/PlacePicker.java:35: PlaceController<? super P> placeController, Renderer<P> renderer) { confirm / document the super P requirement http://gwt-code-reviews.appspot.com/251801/diff/8001/9003 File bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9003#newcode50 bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:50: return null; back this out? http://gwt-code-reviews.appspot.com/251801/diff/8001/9004 File bikeshed/src/com/google/gwt/sample/expenses/client/DetailsRequester.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9004#newcode59 bikeshed/src/com/google/gwt/sample/expenses/client/DetailsRequester.java:59: final StringBuilder list = new StringBuilder("<dl>"); no more dl http://gwt-code-reviews.appspot.com/251801/diff/8001/9004#newcode62 bikeshed/src/com/google/gwt/sample/expenses/client/DetailsRequester.java:62: // at the moment we know we already have them, such as they are. do the request anyway. http://gwt-code-reviews.appspot.com/251801/diff/8001/9004#newcode101 bikeshed/src/com/google/gwt/sample/expenses/client/DetailsRequester.java:101: list.append("</dl>"); no more dl, idiot http://gwt-code-reviews.appspot.com/251801/diff/8001/9006 File bikeshed/src/com/google/gwt/sample/expenses/client/EntityListView.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9006#newcode39 bikeshed/src/com/google/gwt/sample/expenses/client/EntityListView.java:39: Command getShowCommand(); getShowDetailsCommand http://gwt-code-reviews.appspot.com/251801/diff/8001/9011 File bikeshed/src/com/google/gwt/sample/expenses/client/ListRequester.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9011#newcode60 bikeshed/src/com/google/gwt/sample/expenses/client/ListRequester.java:60: final String name = listNameFilter.render(newPlace); Get rid of ListPlaceRenderer, it's silly. http://gwt-code-reviews.appspot.com/251801/diff/8001/9014 File bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityDetailsPlace.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9014#newcode29 bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityDetailsPlace.java:29: public EntityDetailsPlace(Values<? extends ExpensesEntity<?>> entity) { // TODO Probably bad to be passing in the values object here rather than its id. But we no longer have first class ID objects. A dilemma. http://gwt-code-reviews.appspot.com/251801/diff/8001/9016 File bikeshed/src/com/google/gwt/sample/expenses/client/place/ExpenseEntityPlace.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9016#newcode24 bikeshed/src/com/google/gwt/sample/expenses/client/place/ExpenseEntityPlace.java:24: public abstract class ExpenseEntityPlace extends ExpensesPlace { rename AbstractExpenseEntityPlace? http://gwt-code-reviews.appspot.com/251801/diff/8001/9022 File bikeshed/src/com/google/gwt/sample/expenses/shared/EmployeeKey.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9022#newcode36 bikeshed/src/com/google/gwt/sample/expenses/shared/EmployeeKey.java:36: public class EmployeeKey implements ExpensesEntity<EmployeeKey> { ExpenseEntityKey Value.getPropertyHolder > Values.getKey http://gwt-code-reviews.appspot.com/251801/diff/8001/9028 File bikeshed/src/com/google/gwt/valuestore/shared/Values.java (right): http://gwt-code-reviews.appspot.com/251801/diff/8001/9028#newcode24 bikeshed/src/com/google/gwt/valuestore/shared/Values.java:24: T getPropertyHolder(); getKey http://gwt-code-reviews.appspot.com/251801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
