LGTM with nits, but Lex should double-check the CompilePerms change.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17015 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/160801/diff/16001/17015#newcode240 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:240: ResolveRebinds.exec(jprogram, permutation); Actually, it doesn't. :) http://gwt-code-reviews.appspot.com/160801/diff/70001/71022 File dev/core/src/com/google/gwt/dev/jjs/impl/ResolveRebinds.java (right): http://gwt-code-reviews.appspot.com/160801/diff/70001/71022#newcode197 dev/core/src/com/google/gwt/dev/jjs/impl/ResolveRebinds.java:197: for (int i = 0, j = orderedPropertyOracles.length; i < j; i++) { Change this to orderedRebindAnswers.length, and you don't need the property oracles at all. http://gwt-code-reviews.appspot.com/160801/diff/70001/71022#newcode236 dev/core/src/com/google/gwt/dev/jjs/impl/ResolveRebinds.java:236: JExpression mosteUsedExpression = null; "moste"? :) http://gwt-code-reviews.appspot.com/160801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
