Reviewers: Ray Ryan,
Message:
You like?
Description:
This change fixes the conflict with checkstyle when initializing an
anootation value with an array.
Was:
@ShowcaseStyle( {
".gwt-PopupPanel", "html>body .gwt-PopupPanel", "* html
.gwt-PopupPanel",
".gwt-DecoratedPopupPanel", "html>body .gwt-DecoratedPopupPanel",
"* html .gwt-DecoratedPopupPanel"})
Now:
@ShowcaseStyle({
".gwt-PopupPanel", "html>body .gwt-PopupPanel", "* html
.gwt-PopupPanel",
".gwt-DecoratedPopupPanel", "html>body .gwt-DecoratedPopupPanel",
"* html .gwt-DecoratedPopupPanel"})
The first one trips a checkstyle warning.
Please review this at http://gwt-code-reviews.appspot.com/279801/show
Affected files:
M eclipse/settings/code-style/gwt-format.xml
Index: eclipse/settings/code-style/gwt-format.xml
diff --git a/eclipse/settings/code-style/gwt-format.xml
b/eclipse/settings/code-style/gwt-format.xml
index
6e486934dd22884c7a7466fbb153d86c3256b4d7..f4d218cc412c08a0a2aaf3c64e3d48fd4c1ae2c5
100644
--- a/eclipse/settings/code-style/gwt-format.xml
+++ b/eclipse/settings/code-style/gwt-format.xml
@@ -115,7 +115,7 @@
<setting
id="org.eclipse.jdt.core.formatter.insert_space_after_opening_bracket_in_array_allocation_expression"
value="do not insert"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_annotation"
value="do not insert"/>
<setting id="org.eclipse.jdt.core.formatter.comment.format_block_comments"
value="true"/>
-<setting
id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_array_initializer"
value="insert"/>
+<setting
id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_array_initializer"
value="do not insert"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_new_line_in_empty_anonymous_type_declaration"
value="insert"/>
<setting
id="org.eclipse.jdt.core.formatter.alignment_for_binary_expression"
value="16"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_between_empty_braces_in_array_initializer"
value="do not insert"/>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words "REMOVE ME" as the subject.
