http://gwt-code-reviews.appspot.com/184802/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java (right):

http://gwt-code-reviews.appspot.com/184802/diff/1/2#newcode294
dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java:294: void
setClinitTo(JDeclaredType newClinitTarget) {
On 2010/04/02 19:31:36, Lex wrote:
setClinitTarget sounds great.

Done.

http://gwt-code-reviews.appspot.com/184802/diff/1/2#newcode299
dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java:299:
removeClinit();
Okay, after talking this over, it appears removeClinit() has no other
callers, so I inlined it here.  Then after I inlined it, I realized
'null' doesn't need to be special-cased at all, so I just removed this
if block.

http://gwt-code-reviews.appspot.com/184802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right):

http://gwt-code-reviews.appspot.com/184802/diff/1/3#newcode654
dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java:654:
type.setClinitTo(target);
On 2010/04/02 19:31:36, Lex wrote:
I see now.  The superclass is always done first.

Perhaps say *why* the superclass is done first, in the comment at 645?

Done.

http://gwt-code-reviews.appspot.com/184802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to