Reviewers: jgw, Dan Rice,
Description:
This patch replaces HasKey with ProvidesKey, and ListModel now extends
it. As a result, Columns and NodeInfo no longer need to override
getKey(). The default implementation returns the object itself, but can
be optionally overridden.
I removed setSelected(List, selected) from the SelectionModel. Instead,
setSelected(T, selected) now fires the handlers in a finally command, so
users can select/deselect multiple items at a time in the same event
loop without notifying (and rendering) the views multiple times.
This patch also fixes some flow logic in PagingTableListView so that we
only register the list handler when attached to the page.
Please review this at http://gwt-code-reviews.appspot.com/307801/show
Affected files:
bikeshed/src/com/google/gwt/bikeshed/list/client/Column.java
bikeshed/src/com/google/gwt/bikeshed/list/client/HasKey.java
bikeshed/src/com/google/gwt/bikeshed/list/client/PagingTableListView.java
bikeshed/src/com/google/gwt/bikeshed/list/client/SimpleColumn.java
bikeshed/src/com/google/gwt/bikeshed/list/client/TextColumn.java
bikeshed/src/com/google/gwt/bikeshed/list/shared/AbstractListModel.java
bikeshed/src/com/google/gwt/bikeshed/list/shared/ListModel.java
bikeshed/src/com/google/gwt/bikeshed/list/shared/ProvidesKey.java
bikeshed/src/com/google/gwt/bikeshed/list/shared/SelectionModel.java
bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeNodeView.java
bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeViewModel.java
bikeshed/src/com/google/gwt/sample/bikeshed/mail/client/MailSample.java
bikeshed/src/com/google/gwt/sample/bikeshed/stocks/client/StocksDesktop.java
bikeshed/src/com/google/gwt/sample/bikeshed/stocks/client/StocksMobile.java
bikeshed/src/com/google/gwt/sample/bikeshed/stocks/client/TransactionTreeViewModel.java
bikeshed/src/com/google/gwt/sample/bikeshed/stocks/shared/StockQuote.java
bikeshed/src/com/google/gwt/sample/bikeshed/tree/client/TreeSample.java
bikeshed/src/com/google/gwt/sample/bikeshed/validation/client/Validation.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using "remove me" as the subject.
