Lgtm On Apr 7, 2010 11:36 AM, <[email protected]> wrote:
Reviewers: Ray Ryan, Description: Checkstyle fixes. Review by: [email protected] Please review this at http://gwt-code-reviews.appspot.com/320801/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java M bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java M bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesServerSideOperations.java M bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java M bikeshed/src/com/google/gwt/valuestore/client/ListModelAdapter.java M bikeshed/src/com/google/gwt/valuestore/client/ValuesListViewTable.java Index: bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java =================================================================== --- bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java (revision 7882) +++ bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java (working copy) @@ -16,7 +16,6 @@ package com.google.gwt.requestfactory.shared; import com.google.gwt.event.shared.HandlerManager; -import com.google.gwt.requestfactory.server.RequestFactoryServlet; import com.google.gwt.valuestore.shared.DeltaValueStore; import com.google.gwt.valuestore.shared.ValueStore; import com.google.gwt.valuestore.shared.ValuesKey; Index: bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java =================================================================== --- bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java (revision 7882) +++ bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java (working copy) @@ -24,6 +24,10 @@ * Request selector. */ public interface EmployeeRequest { + + /** + * Enum for server operations. + */ public enum ServerOperations implements RequestFactory.RequestDefinition { FIND_ALL_EMPLOYEES { public String getDomainMethodName() { Index: bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesServerSideOperations.java =================================================================== --- bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesServerSideOperations.java (revision 7882) +++ bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesServerSideOperations.java (working copy) @@ -25,7 +25,7 @@ /** * Configuration class for * {...@link com.google.gwt.requestfactory.server.RequestFactoryServlet - * RequestFactoryServlet} + * RequestFactoryServlet}. */ public class ExpensesServerSideOperations implements Config { Index: bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java =================================================================== --- bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java (revision 7882) +++ bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java (working copy) @@ -26,6 +26,10 @@ * Request selector. */ public interface ReportRequest { + + /** + * Enum for server operations. + */ public enum ServerOperations implements RequestFactory.RequestDefinition { FIND_REPORTS_BY_EMPLOYEE { public String getDomainMethodName() { Index: bikeshed/src/com/google/gwt/valuestore/client/ListModelAdapter.java =================================================================== --- bikeshed/src/com/google/gwt/valuestore/client/ListModelAdapter.java (revision 7882) +++ bikeshed/src/com/google/gwt/valuestore/client/ListModelAdapter.java (working copy) @@ -25,7 +25,7 @@ /** * Simple adapter from a {...@link com.google.gwt.valuestore.shared.ValueStore * ValueStore} to a {...@link com.google.gwt.bikeshed.list.shared.ListModel - * ListModel} + * ListModel}. * <p> * TODO: pay attention to the visible range info that subclasses receive via * {...@link #onRangeChanged} Index: bikeshed/src/com/google/gwt/valuestore/client/ValuesListViewTable.java =================================================================== --- bikeshed/src/com/google/gwt/valuestore/client/ValuesListViewTable.java (revision 7882) +++ bikeshed/src/com/google/gwt/valuestore/client/ValuesListViewTable.java (working copy) @@ -33,7 +33,7 @@ /** * A widget that displays lists of {...@link com.google.gwt.valuestore.ValueStore - * ValueStore} records in a {...@link PagingTableListView} + * ValueStore} records in a {...@link PagingTableListView}. * <p> * TODO needs MVP separation * -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.
