Drive me crazy that the reply box at the bottom doesn't include comments!
http://gwt-code-reviews.appspot.com/328801/diff/1/3 File bikeshed/src/com/google/gwt/sample/expenses/gwt/place/ApplicationListPlace.java (right): http://gwt-code-reviews.appspot.com/328801/diff/1/3#newcode25 bikeshed/src/com/google/gwt/sample/expenses/gwt/place/ApplicationListPlace.java:25: public class ApplicationListPlace extends ExpensesPlace { Unused class, deleted. http://gwt-code-reviews.appspot.com/328801/diff/1/4 File bikeshed/src/com/google/gwt/sample/expenses/gwt/place/ApplicationPlaces.java (right): http://gwt-code-reviews.appspot.com/328801/diff/1/4#newcode26 bikeshed/src/com/google/gwt/sample/expenses/gwt/place/ApplicationPlaces.java:26: public class ApplicationPlaces { Unused class, deleted. http://gwt-code-reviews.appspot.com/328801/diff/1/13 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/AllEmployeesRequester.java (right): http://gwt-code-reviews.appspot.com/328801/diff/1/13#newcode42 bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/AllEmployeesRequester.java:42: view.getProperties()).to(view).fire(); On 2010/04/08 16:53:46, amitmanjhi wrote:
Add a TODO here that start and length are not currently being used?
Done. http://gwt-code-reviews.appspot.com/328801/diff/1/15 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListView.java (right): http://gwt-code-reviews.appspot.com/328801/diff/1/15#newcode73 bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListView.java:73: return properties; Made it a field. http://gwt-code-reviews.appspot.com/328801/diff/1/16 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/AllReportsRequester.java (right): http://gwt-code-reviews.appspot.com/328801/diff/1/16#newcode44 bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/AllReportsRequester.java:44: } On 2010/04/08 16:53:46, amitmanjhi wrote:
Add a TODO that start and length are not being used.
Done. http://gwt-code-reviews.appspot.com/328801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.
