Revision: 7921
Author: [email protected]
Date: Wed Apr 14 10:17:19 2010
Log: Move logic to send initial onRangedChanged to
AbstractListViewAdapter.addView instead of ListView.setDelegate
Review at http://gwt-code-reviews.appspot.com/349801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=7921
Modified:
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/PagingTableListView.java
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/SimpleCellList.java
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/shared/AbstractListViewAdapter.java
/trunk/bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeNodeView.java
=======================================
---
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/PagingTableListView.java
Tue Apr 13 18:19:04 2010
+++
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/PagingTableListView.java
Wed Apr 14 10:17:19 2010
@@ -231,9 +231,6 @@
public void setDelegate(Delegate<T> delegate) {
this.delegate = delegate;
- if (delegate != null) {
- delegate.onRangeChanged(this);
- }
}
/**
=======================================
---
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/SimpleCellList.java
Tue Apr 13 18:19:04 2010
+++
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/SimpleCellList.java
Wed Apr 14 10:17:19 2010
@@ -144,9 +144,6 @@
public void setDelegate(Delegate<T> delegate) {
this.delegate = delegate;
- if (delegate != null) {
- delegate.onRangeChanged(this);
- }
}
public void setValueUpdater(ValueUpdater<T, Void> valueUpdater) {
=======================================
---
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/shared/AbstractListViewAdapter.java
Tue Apr 13 18:19:04 2010
+++
/trunk/bikeshed/src/com/google/gwt/bikeshed/list/shared/AbstractListViewAdapter.java
Wed Apr 14 10:17:19 2010
@@ -71,12 +71,19 @@
*/
private ProvidesKey<T> keyProvider;
+ /**
+ * Adds a view to this adapter. The current range of interest of the
view
+ * will be populated with data.
+ *
+ * @param view a {...@link ListView}.
+ */
public void addView(ListView<T> view) {
if (views.contains(view)) {
throw new IllegalStateException("ListView already added");
}
views.add(view);
view.setDelegate(delegate);
+ delegate.onRangeChanged(view);
}
/**
=======================================
---
/trunk/bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeNodeView.java
Wed Apr 14 09:41:18 2010
+++
/trunk/bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeNodeView.java
Wed Apr 14 10:17:19 2010
@@ -475,9 +475,6 @@
public void setDelegate(ListView.Delegate<C> delegate) {
// Range never actually changes so no need to store the delegate
- if (delegate != null) {
- delegate.onRangeChanged(this);
- }
}
};
nodeInfo.setView(view);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using "remove me" as the subject.
