LGTM

http://gwt-code-reviews.appspot.com/357801/diff/1/5
File user/super/com/google/gwt/emul/java/util/Collections.java (right):

http://gwt-code-reviews.appspot.com/357801/diff/1/5#newcode121
user/super/com/google/gwt/emul/java/util/Collections.java:121: return
(item == element) || (item != null && item.equals(element));
I think we already have equalsWithNullCheck that will do this.

http://gwt-code-reviews.appspot.com/357801/diff/1/10
File user/test/com/google/gwt/user/client/rpc/TestSetValidator.java
(right):

http://gwt-code-reviews.appspot.com/357801/diff/1/10#newcode540
user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:540:
"singleton".equals(list.get(0).getValue());
Should there be an instanceof check here?

http://gwt-code-reviews.appspot.com/357801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to