Reviewers: Dan Rice,
Description:
Two small fixes:
- on my work laptop I would get lines way too big for the font size,
and on my home machine the underscores would get dropped because the
lines weren't quite large enough. I'm not positive this is the right
way to handle it, but it works properly on both machines now.
- the SwitchTransport response was missing a flush, so that when a
client supporting ChooseTransports connects, things will hang.
Please review this at http://gwt-code-reviews.appspot.com/350803/show
Affected files:
dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java
dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Index: dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===================================================================
--- dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
(revision 7948)
+++ dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
(working copy)
@@ -32,6 +32,7 @@
import java.awt.Dimension;
import java.awt.FlowLayout;
import java.awt.Font;
+import java.awt.FontMetrics;
import java.awt.HeadlessException;
import java.awt.Point;
import java.awt.datatransfer.Clipboard;
@@ -392,6 +393,9 @@
Font font = UIManager.getFont("Label.font");
String bodyRule = "body { font-family: " + font.getFamily() + "; "
+ "font-size: " + font.getSize() + "pt; }";
+ FontMetrics fontMetrics = tree.getFontMetrics(font);
+ tree.setRowHeight(fontMetrics.getMaxAscent() +
fontMetrics.getMaxDescent()
+ + fontMetrics.getLeading() + 1);
((HTMLDocument)
details.getDocument()).getStyleSheet().addRule(bodyRule);
JScrollPane msgView = new JScrollPane(details);
JSplitPane splitter = new JSplitPane(JSplitPane.VERTICAL_SPLIT);
Index: dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java
===================================================================
--- dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java (revision
7948)
+++ dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java (working copy)
@@ -1386,6 +1386,7 @@
stream.writeByte(MessageType.SWITCH_TRANSPORT.getId());
writeUtf8String(stream, transport);
writeUtf8String(stream, transportArgs);
+ stream.flush();
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
