Reviewers: amitmanjhi,
Description:
If the module fails to startup, an NPE can get tripped here.
Please review this at http://gwt-code-reviews.appspot.com/375801/show
Affected files:
M user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
Index: user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
diff --git a/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
b/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
index
adf4af8643a829f9e2e7c94bb8633b2fb3cd1efe..ed967e5455b2e1001cc67aa43b706f9c692ec0d8
100644
--- a/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
+++ b/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
@@ -57,11 +57,13 @@ class RunStyleExternalBrowser extends RunStyle {
@Override
public void run() {
for (ExternalBrowser browser : externalBrowsers) {
- try {
- browser.getProcess().exitValue();
- } catch (IllegalThreadStateException e) {
- // The process is still active. Kill it.
- browser.getProcess().destroy();
+ if (browser.getProcess() != null) {
+ try {
+ browser.getProcess().exitValue();
+ } catch (IllegalThreadStateException e) {
+ // The process is still active. Kill it.
+ browser.getProcess().destroy();
+ }
}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
