Done, thanks for the review.
http://gwt-code-reviews.appspot.com/338801/diff/23001/24002 File user/src/com/google/gwt/i18n/shared/DirectionEstimator.java (right): http://gwt-code-reviews.appspot.com/338801/diff/23001/24002#newcode28 user/src/com/google/gwt/i18n/shared/DirectionEstimator.java:28: bidiUtils = BidiUtils.get(); On 2010/04/19 23:48:31, jat wrote:
No need to keep this instance, since it is a singleton anyway. Just
inline
BidiUtils.get() everywhere you reference bidiUtils here and in
subclasses. Done. http://gwt-code-reviews.appspot.com/338801/diff/23001/24005 File user/src/com/google/gwt/i18n/shared/WordCountDirectionEstimator.java (right): http://gwt-code-reviews.appspot.com/338801/diff/23001/24005#newcode23 user/src/com/google/gwt/i18n/shared/WordCountDirectionEstimator.java:23: * Note: this is probably the recommended estimator for most use cases. On 2010/04/19 23:46:11, jat wrote:
Add <p> to the beginning of this line.
Done. http://gwt-code-reviews.appspot.com/338801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
