http://gwt-code-reviews.appspot.com/367803/diff/1/3 File /bikeshed/src/com/google/gwt/collections/Map.java (right):
http://gwt-code-reviews.appspot.com/367803/diff/1/3#newcode35 /bikeshed/src/com/google/gwt/collections/Map.java:35: public abstract boolean containsKey(K key); On 2010/04/29 15:59:11, Dan Rice wrote:
Can K be null? Need to document what happens.
Done. It depends on the concrete implementation. http://gwt-code-reviews.appspot.com/367803/diff/1/3#newcode43 /bikeshed/src/com/google/gwt/collections/Map.java:43: public abstract V get(K key); On 2010/04/29 15:59:11, Dan Rice wrote:
Can K be null? Need to document what happens.
Done. It depends on the concrete implementation. http://gwt-code-reviews.appspot.com/367803/diff/1/4 File /bikeshed/src/com/google/gwt/collections/MutableMap.java (right): http://gwt-code-reviews.appspot.com/367803/diff/1/4#newcode32 /bikeshed/src/com/google/gwt/collections/MutableMap.java:32: public abstract boolean containsKey(K key); On 2010/04/29 15:59:11, Dan Rice wrote:
No need to redeclare the three methods from Map.
Done. http://gwt-code-reviews.appspot.com/367803/diff/1/4#newcode47 /bikeshed/src/com/google/gwt/collections/MutableMap.java:47: public abstract void put(K key, V value); On 2010/04/29 15:59:11, Dan Rice wrote:
Can K or V be null? Need to document what happens.
Similar to Map, the behavior depends on the implementation. Added documentation at the class level. http://gwt-code-reviews.appspot.com/367803/diff/1/4#newcode54 /bikeshed/src/com/google/gwt/collections/MutableMap.java:54: public abstract void remove(K key); On 2010/04/29 15:59:11, Dan Rice wrote:
Can K be null? Need to document what happens.
Added documentation at the class level. http://gwt-code-reviews.appspot.com/367803/diff/1/5 File /bikeshed/src/com/google/gwt/collections/MutableStringMap.java (right): http://gwt-code-reviews.appspot.com/367803/diff/1/5#newcode21 /bikeshed/src/com/google/gwt/collections/MutableStringMap.java:21: * A Map whose keys are supported by Strings. On 2010/04/29 15:59:11, Dan Rice wrote:
I'm assuming this is just the dev mode implementation with a JS
implementation
to follow?
Yes, documented that this implementation is the byte code one. Also described behavior around null keys and values. http://gwt-code-reviews.appspot.com/367803/diff/1/5#newcode56 /bikeshed/src/com/google/gwt/collections/MutableStringMap.java:56: initEntries(); On 2010/04/29 15:59:11, Dan Rice wrote:
Why not just inline initEntries here since this is the only call site
Done. http://gwt-code-reviews.appspot.com/367803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
