I'd been tracking down this error, which was initially convolved with some
code I'd added to Hello for an unrelated issue I was tracking with
Kathryn... but I don't have a good explanation why I'm now seeing zero-based
values.  But it seems, AFAICT, legit....

On Mon, May 3, 2010 at 1:43 PM, <[email protected]> wrote:

> Reviewers: Lex,
>
> Description:
> Correcting the output names for SoycTest.java
>
> Review by: [email protected]
>
> Please review this at http://gwt-code-reviews.appspot.com/442801/show
>
> Affected files:
>  M dev/core/test/com/google/gwt/dev/SoycTest.java
>
>
> Index: dev/core/test/com/google/gwt/dev/SoycTest.java
> ===================================================================
> --- dev/core/test/com/google/gwt/dev/SoycTest.java      (revision 8015)
> +++ dev/core/test/com/google/gwt/dev/SoycTest.java      (working copy)
> @@ -43,12 +43,17 @@
>     new Compiler(options).run(logger);
>
>     // make sure the files have been produced
> -    assertTrue(new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/index.html").exists());
> -    assertTrue(new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/SoycDashboard-1-index.html").exists());
> -    assertTrue(new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/total-1-overallBreakdown.html").exists());
> -    assertTrue(new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/soyc.css").exists());
> +    assertTrue("missing compile-report/index.html",
> +               new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/index.html").exists());
> +    assertTrue("missing compile-report/SoycDashboard-0-index.html",
> +               new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/SoycDashboard-0-index.html").exists());
> +    assertTrue("missing compile-report/total-0-overallBreakdown.html",
> +               new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/total-0-overallBreakdown.html").exists());
> +    assertTrue("missing compile-report/soyc.css",
> +               new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/soyc.css").exists());
>
> -    assertFalse(new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/index2.html").exists());
> +    assertFalse("improperly has compile-report/index2.html",
> +                new File(options.getExtraDir() +
> "/hello/soycReport/compile-report/index2.html").exists());
>     Util.recursiveDelete(options.getExtraDir(), false);
>   }
>  }
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to