http://gwt-code-reviews.appspot.com/437801/diff/8001/9003 File /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java (right):
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode33 /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:33: protected static class LogManagerWithExposedConstructor extends LogManager { On 2010/05/04 16:34:03, scottb wrote:
Checkstyle wants this to have Javadoc since it's protected. Or you
could just
make it default access.
Done. http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode52 /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:52: serverLogManager = new LogManagerWithExposedConstructor(); On 2010/05/04 16:34:03, scottb wrote:
Would it do any good to log the error to the newly-created logger? Or
does it
just go into the bit bucket if there are no handlers set up yet?
logging won't work at this point, but I added some output to System.err http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode73 /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:73: public Enumeration getLoggerNames() { On 2010/05/04 16:34:03, scottb wrote:
Return Enumeration<String> instead of the unchecked.
Done. http://gwt-code-reviews.appspot.com/437801/diff/8001/9004 File /dev/core/test/com/google/gwt/dev/DevModeBaseTest.java (right): http://gwt-code-reviews.appspot.com/437801/diff/8001/9004#newcode23 /dev/core/test/com/google/gwt/dev/DevModeBaseTest.java:23: static final String NEW_MANAGER = "com.google.gwt.dev.shell.DevModeLogManager"; On 2010/05/04 16:34:03, scottb wrote:
Nit: wrong sort order for OLD/NEW. :)
Done. http://gwt-code-reviews.appspot.com/437801/diff/8001/9005 File /dev/core/test/com/google/gwt/dev/shell/DevModeLogManagerTest.java (right): http://gwt-code-reviews.appspot.com/437801/diff/8001/9005#newcode46 /dev/core/test/com/google/gwt/dev/shell/DevModeLogManagerTest.java:46: assertTrue(devManager.serverLogManager instanceof LogManager); On 2010/05/04 16:34:03, scottb wrote:
Eclipse warns me that the instanceof test cannot possibly be false.
Are you
just null-checking, or are you looking for a specific type?
Done. http://gwt-code-reviews.appspot.com/437801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
