All nits picked, fixed, and committed.
http://gwt-code-reviews.appspot.com/467801/diff/1/60 File /user/src/com/google/gwt/cell/client/ActionCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/60#newcode55 /user/src/com/google/gwt/cell/client/ActionCell.java:55: On 2010/05/05 16:19:51, jlabanca wrote:
Should implement consumesEvent() to return true.
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/60#newcode59 /user/src/com/google/gwt/cell/client/ActionCell.java:59: if ("mouseup".equals(event.getType())) { On 2010/05/05 16:19:51, jlabanca wrote:
We should probably use click here.
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/64 File /user/src/com/google/gwt/cell/client/ClickableTextCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/64#newcode30 /user/src/com/google/gwt/cell/client/ClickableTextCell.java:30: On 2010/05/05 16:19:51, jlabanca wrote:
implement consumesEvents, return true
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/65 File /user/src/com/google/gwt/cell/client/CompositeCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/65#newcode26 /user/src/com/google/gwt/cell/client/CompositeCell.java:26: * A {...@link Cell} that is composed of other {...@link AbstractCell}s. On 2010/05/05 16:19:51, jlabanca wrote:
Cell, not AbstractCell.
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/65#newcode30 /user/src/com/google/gwt/cell/client/CompositeCell.java:30: * When this cell is rendered, it will render each component {...@link AbstractCell} inside On 2010/05/05 16:19:51, jlabanca wrote:
Cell
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/65#newcode31 /user/src/com/google/gwt/cell/client/CompositeCell.java:31: * a span. If the component {...@link AbstractCell} uses block level elements (such as a On 2010/05/05 16:19:51, jlabanca wrote:
Cell
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/69 File /user/src/com/google/gwt/cell/client/EditTextCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/69#newcode35 /user/src/com/google/gwt/cell/client/EditTextCell.java:35: On 2010/05/05 16:19:51, jlabanca wrote:
Implement consumesEvents
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/69#newcode68 /user/src/com/google/gwt/cell/client/EditTextCell.java:68: String value; On 2010/05/05 16:19:51, jlabanca wrote:
value can be declared on the next line where it is set.
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/70 File /user/src/com/google/gwt/cell/client/FieldUpdater.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/70#newcode32 /user/src/com/google/gwt/cell/client/FieldUpdater.java:32: * Announces a new value for a field within a base object. On 2010/05/05 16:19:51, jlabanca wrote:
Add newline between description and @param tags
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/71 File /user/src/com/google/gwt/cell/client/HasCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/71#newcode20 /user/src/com/google/gwt/cell/client/HasCell.java:20: * of type T, provide a {...@link AbstractCell} to render that value, and provide a On 2010/05/05 16:19:51, jlabanca wrote:
Cell, not AbstractCell
Done. http://gwt-code-reviews.appspot.com/467801/diff/1/71#newcode33 /user/src/com/google/gwt/cell/client/HasCell.java:33: * Returns the {...@link AbstractCell} of type C. On 2010/05/05 16:19:51, jlabanca wrote:
Cell
Done. http://gwt-code-reviews.appspot.com/467801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
