Cursory review of the non-dev code.  Having .cast() not work would
bother me.  Will get to the dev code soon.


http://gwt-code-reviews.appspot.com/473801/diff/5001/6015
File user/src/com/google/gwt/user/client/DOM.java (right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6015#newcode750
user/src/com/google/gwt/user/client/DOM.java:750: return (Element)
Document.get().getElementById(id);
This change doesn't make sense to me.  At some point, the bytecode
really has to do a cast operation to Element.  Is this necessary?  If
so, I think something is broken.

http://gwt-code-reviews.appspot.com/473801/diff/5001/6016
File user/src/com/google/gwt/user/client/ui/RootPanel.java (right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6016#newcode286
user/src/com/google/gwt/user/client/ui/RootPanel.java:286: element =
element.getParentElement();
Again.. necessary?

http://gwt-code-reviews.appspot.com/473801/diff/5001/6019
File user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java
(right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6019#newcode960
user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java:960: public
void XXXtestCreatedWithCast() {
Sounds like this whole test and a lot of code wants to be deleted.

http://gwt-code-reviews.appspot.com/473801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to