LGTM after addressing nits.

http://gwt-code-reviews.appspot.com/517801/diff/1/5
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode56
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:56:
private boolean itsMeDoingTheSelecting = false;
nit. wouldnt block on this.

But it seems like this state tries to accomplish the same thing as
"don't redisplay the same thing that is already displayed".

Can we not somehow just check the currently selected with the thing we
want to select?

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode76
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:76:
// TODO
empty todo

http://gwt-code-reviews.appspot.com/517801/diff/1/6
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/6#newcode45
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java:45:

space

http://gwt-code-reviews.appspot.com/517801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to